Small log improvements #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints. |
Schamper
requested changes
Oct 7, 2024
Co-authored-by: Erik Schamper <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 76.68% 76.69%
=======================================
Files 316 316
Lines 27103 27109 +6
=======================================
+ Hits 20784 20790 +6
Misses 6319 6319
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two small issues:
--hashas a lot of files can be broken. this log is now demoted to INFO forFileNotFoundErrors as that exception is not really interesting in those instances.--childrenor target-shell'senterthe path of said child was appended to the locations of where to look for targetcfg files. That obviously does not work as that path is virtual inside the main target. This is now fixed.Fixes #880 and fixes #881.